Turn an issue into a pull request

What you ask

Search Acme

support

Today
Fabian 10:15 AM

@devboxes can you pick up DEV-31? enterprise customers get payment reminders before their grace period is over
devboxes APP 10:31 AM
Looked at 4 sources
1. Read DEV-31 and its comments
2. Opened src/dunning/schedule.ts
3. Found gracePeriodDays on customers
4. Moved DEV-31 to In Review
#52 is up. The first reminder now waits out the customer's grace period, which was already on the customer record. Checks pass and DEV-31 is in review.

Opened #52
Fabian 1:40 PM

@devboxes Nina wants the grace period on #52 in business days, that's how the contracts are written
devboxes APP 1:52 PM
Looked at 3 sources
1. Read Nina's comment on #52
2. Found the reminders' calendar
3. Ran the tests
Done. #52 now counts business days with the same calendar the reminders use, and there's a test for a due date right before a weekend.

Updated #52
devboxes is working…

Read the request
- devboxes turns the request into acceptance criteria that can be checked.
Find the code
- Then it finds the files to change and the tests that cover them.
Make the change
- The change meets every acceptance criterion.
- Tests cover the change.
Verify
1. Install dependencies
2. Test
3. Lint
4. If it fails
  1. Fix
    - The tests pass.
  2. Test again
  3. Lint again
Publish
Review

DEV-31Payment reminders ignore the enterprise grace periodFiled by Jonas. Enterprise contracts grant a grace period, but the first reminder goes out one day after the due date.
#52Respect the contract's grace period before remindingBusiness days come from the calendar the reminders already use, so public holidays count the same way in both.

Startups