support
@devboxes can you pick up 
DEV-31? enterprise customers get payment reminders before their grace period is over
Looked at 4 sources Read DEV-31 and its comments Opened src/dunning/schedule.ts Found gracePeriodDays on customers Moved DEV-31 to In Review #52 is up. The first reminder now waits out the customer's grace period, which was already on the customer record. Checks pass and DEV-31 is in review.
Jira
DEV-31 Payment reminders ignore the enterprise grace period
In Review Dunning
GitHub
#52 Respect the contract's grace period before reminding
Open
devboxes/dev-31 3 checks passed
Opened #52
@devboxes Nina wants the grace period on #52 in business days, that's how the contracts are written
Looked at 3 sources Read Nina's comment on #52 Found the reminders' calendar Ran the tests Done. #52 now counts business days with the same calendar the reminders use, and there's a test for a due date right before a weekend.
Updated #52
Filed by Jonas. Enterprise contracts grant a grace period, but the first reminder goes out one day after the due date.
devboxes linked #52
devboxes moved the ticket to In Review
devboxes Bot reviewed 2 minutes ago View reviewed changes
3 successful checks
Merging can be performed automatically.
You can also merge this with the command line.
src/dunning/schedule.ts +16 −4 test/dunning-grace-period.test.ts +38 −0 engineering
@devboxes can you take ENG-410? the invoice date shows the wrong month in December
#89 fixes ENG-410. December invoices took their month from the billing run on January 1. A test covers the change of year, and checks pass.
Opened #89
engineering
@devboxes Fabian's out today, can you review #88 before I merge it?
Reviewed #88. A refund on a cancelled invoice books twice, and I left an example on that line. The rest of the change is fine.
Review posted
engineering
@devboxes CI is red on #91 but the tests pass locally. what's going on?
The failing test depends on the time zone. CI runs in UTC, so the due date in the test moves back a day. Setting the time zone in the test fixes it.
alerts
Looked at 4 sources Read the new alert Found where the invoice export reads the amount Found Tuesday's change to it Wrote a test that fails with the same error Sentry's new alert is the invoice export failing on invoices without a coupon, since Tuesday's release. #61 adds a test that fails the same way and the fix that makes it pass. All checks pass.
GitHub
#61 Treat a missing coupon as no discount
Open
devboxes/invoice-export-coupon 3 checks passed
Ready for review
devboxes Bot reviewed 2 minutes ago View reviewed changes
devboxes Bot left a comment
Invoices with a coupon export as before, and invoices without one no longer break the export. No findings.
3 successful checks
Merging can be performed automatically.
You can also merge this with the command line.
src/invoices/export.ts +4 −1 src/invoices/export.test.ts +28 −0 devboxes reads the instructions your team already keeps with its code and runs your own tests.
After your tests pass, a separate review looks for problems and devboxes fixes what it finds.
On GitHub or GitLab. devboxes also reads CI results from Gitea and Forgejo.
devboxes Bot left a comment Author
Business days come from the calendar the reminders already use, so public holidays count the same way in both.