What you ask
Search Acme
billing
2
-
@devboxes Fabian's out today and I'd like to merge his customer import PR
#46. can you give it a second look first? -
Looked at 3 sources - Read the changes in #46
- Read the change's tests, all with commas
- Imported a file saved by Excel
Two problems the tests miss, both with files saved by German Excel: semicolons put every customer in one column, and a byte order mark drops the first column's name.
-
What devboxes does
-
Read the change
- devboxes reads the pull request's changes, tests and description.
-
Find the cases the tests miss
- You get a list of the cases the tests don't cover.
-
Try those cases
- Each of those cases is tried, with its input and result noted.
-
Report the problems
- Each problem comes with a concrete example of what was expected and what happened.
What you get back
Review of #46
- Finding A file saved by German Excel uses semicolons, so every customer lands in one column.
- Finding A file that starts with a byte order mark loses the name of its first column.
- Suggest Read the separator from the header line, strip the byte order mark, and add both files to the tests.
Good for
Startups